Feature #736
Make feed PubSubHubbub enabled
| Status: | Closed | Start date: | 01/11/2012 | ||
|---|---|---|---|---|---|
| Priority: | Normal | Due date: | |||
| Assignee: | % Done: | 70% |
|||
| Category: | Programming | ||||
| Target version: | 0.2.1 |
Description
I created a branch [1] to make feed PubSubHubbub enabled.
To enable it add these 2 lines to your mediagoblin_local.ini
push_enabled = True
push_url = 'http://pubsubhubbub.appspot.com/'
[1] https://gitorious.org/~macno/mediagoblin/macnos-mediagoblin/commits/pushatom
Related issues
History
Updated by Elvenlord Elrond 4 months ago
- Category set to Programming
- Status changed from New to Feedback
Stupid question: Why not enable just/when/if the url is set?
Two config settings feels a bit "too much"?
Updated by Michele Azzolari 4 months ago
Removed one setting. If push_url is set, we use it
Updated by Elvenlord Elrond 4 months ago
- Assignee set to Elvenlord Elrond
- Target version set to 0.2.1
That looks good!
I'll try to merge this tomorrow.
Updated by Elvenlord Elrond 4 months ago
- Status changed from Feedback to In Progress
- % Done changed from 0 to 70
Hi Michele,
I merged your tree (so please do a git merge upstream/master or equivalent).
But (and that's the reason I'm not closing the bug):
If the remote server is broken (you can easily test this using http://localhost/no-such-file, as a push_urls setting) one gets a big fat error page (urllib2.HTTPError exception).
I am currently unsure what is the best option for this.
My vote is on "catch the exception and add the stringified version of the Exception as a message", so the users gets it. Maybe not the best, but our current userbase will surely know what to do with such a strange thing.
Updated by Elvenlord Elrond 4 months ago
- Assignee changed from Elvenlord Elrond to Michele Azzolari
Updated by Michele Azzolari 4 months ago
I pushed the changes to my branch, check it out
Updated by Elvenlord Elrond 4 months ago
- Status changed from In Progress to Closed
merged!
Great work!